Open
Conversation
tracker now expects a text file with on each line the executable's name and arguments, allowing it to produces multiple traces
perror
reviewed
Jan 16, 2020
Owner
perror
left a comment
perror
left a comment
There was a problem hiding this comment.
Well, this is a full reindentation of the code... Difficult to see what you did change or not... I do not think I will merge this without any visibility of what really change. Yet, I think I'll take your trace_t API.
| /* Free every element in the trace t */ | ||
| void trace_delete (trace_t *t); | ||
|
|
||
| /* Returns a pointer to the first element where t2 differs from t1 */ |
Owner
There was a problem hiding this comment.
It should be mentioned that it returns NULL if both traces are equals.
…ain/.text research
… instructions, to be continued
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.